search

japanoise / emsys

ersatz-emacs text editor
MIT License
3 stars 2 forks source link

Unnecessary dependency on Git #17

Closed nicholascarroll closed 1 year ago

nicholascarroll commented 1 year ago

The version numbering creates a dependency on Git which may not be installed when compiling. It is in the Makefile, consider changing this line: VERSION?=git-$(shell git rev-parse --short HEAD) I am going to be removing it from my fork of the emsys project.

japanoise commented 1 year ago

I think of this as a feature rather than a bug; if you're compiling it by hand you'd best have git installed so you can fetch updates. It also serves as a good way to figure out where someone is in the event of a bug; I can ask them to M-x version and see exactly what commit they're at. A workaround for anyone that doesn't have git installed is to compile emsys with:

make VERSION='i-didnt-install-git'

That should work on systems that don't have git (probably, haven't tested, but VERSION?= should be "set VERSION variable iff it's not already set").