japanoise / emsys

ersatz-emacs text editor
MIT License
3 stars 2 forks source link

Added build options EMSYS_CU_UARG and EMSYS_CUA #28

Closed nicholascarroll closed 1 month ago

nicholascarroll commented 1 month ago

Hi japanoise,

This PR add two build options to allow toggling features in a way that avoids having to have a .emacs file.

BTW when I run make format it is formatting some files differently to yours. Is it that you have only ever formatted some files or could it be that clang-format version I have works differently?

$ clang-format --version
clang-format version 11.0.0 (https://github.com/msys2/MSYS2-packages 9ef552a3c4cc9410d2b1fb6f22a0cdda3bc09a64)

The new build options!

EMSYS_CU_UARG

Enables C-u as Universal Argument. Note, this does not (yet?) work in the minibuffer. If it is disabled, C-u does kill to beginning of line.

EMSYS_CUA

Enables cua-mode: C-x/C-c/C-v become cut/copy/paste if there is a marked region set.

japanoise commented 1 month ago

BTW when I run make format it is formatting some files differently to yours. Is it that you have only ever formatted some files or could it be that clang-format version I have works differently?

Yup, I'm on Arch - big version mismatch!

$ clang-format --version
clang-format version 18.1.8
nicholascarroll commented 1 month ago

I ran it on Ubuntu with clang 14. Hey I have put this back into draft cos I think I need to fix something, BRB

nicholascarroll commented 1 month ago

if you want me to squash down some of my commits so the commit history looks nicer just let me know

nicholascarroll commented 1 month ago

I have put this back to draft to revise. I had added argument E.focusBuf to editorReadKey but now I realize that is not necessary.