search

japanoise / emsys

ersatz-emacs text editor
MIT License
3 stars 2 forks source link

window based scrolling #36

Closed nicholascarroll closed 3 months ago

nicholascarroll commented 3 months ago

issue #32 independent window scrolling. It also includes toggle-truncate-lines, POSIX 2001 compliance and use of tilde for home dir in C-x C-f

nicholascarroll commented 3 months ago

Ok let me replicate that and fix it.

nicholascarroll commented 3 months ago

I fixed the bugs (there was actually 3) but I changed what constitutes window height and then I realized you may not like that. I made window height not include the status bar just because i thought it was a good idea at the time but now i realize that may be confusing. In Emacs there are two: window-body-height which does not include the mode line and window-total-height which does. If you want I can change it back?

Also i forgot to pull before making my fixes and ran out of time to fix that.

nicholascarroll commented 3 months ago

just found another bug. I'll get back in touch when its ready

japanoise commented 3 months ago

I fixed the bugs (there was actually 3) but I changed what constitutes window height and then I realized you may not like that. I made window height not include the status bar just because i thought it was a good idea at the time but now i realize that may be confusing. In Emacs there are two: window-body-height which does not include the mode line and window-total-height which does. If you want I can change it back?

I'm OK with the rendering code being refactored to make hackability better. Change it however is needed to get the functionality working - we can hash out code quality when it's done :smile:

nicholascarroll commented 3 months ago

OK I think this is finally working properly now.

nicholascarroll commented 3 months ago

I added an enhancement to switch buffers: it now has the default switch to previous buffer. So C-b RET.