search

japanoise / emsys

ersatz-emacs text editor
MIT License
3 stars 2 forks source link

Revert editorScroll (#39) and Why uthash? (#33) #38

Closed nicholascarroll closed 1 month ago

nicholascarroll commented 1 month ago

THIS PR HAS BEEN CHANGED: Visual Mark removed Features in this PR:

  1. Reverted code for editorSetScxScy, editorScroll and editorDrawRows per #39
  2. Removed dependency on uthash as per Why uthash? #33 Visual mark was originally in this PR but has been backed out for the time being so that we can go one step at a time.
  3. Kill Line and Kill Line backwards now put their kill on the kill ring.
nicholascarroll commented 1 month ago

I added issue #27 to this just now: editorKillLIne and editorKillLIneBackwards should place kill on the kill ring.

nicholascarroll commented 1 month ago

put on draft because I am rewriting something that went in the last PR> I found bugs in it. Rewrite of editorSetScxScy and editorScroll #39.

japanoise commented 1 month ago

This works fantastically. I'd merge it now, but I noticed some behavior that should be straightforward to fix - note the modeline's line numbers match even though the windows' cursors are in different places:

2024-07-31-19:52:20 2024-07-31-19:52:25

I'd take care of this myself, but as you may be able to guess from the terrible turnaround, I've been slammed with work recently and don't have the energy for hobby programming. If you have time, a fix for this would be very much appreciated; if not this work is fine as-is and we can table this with an issue for later.

nicholascarroll commented 1 month ago

We can't have that! Leave it with me and I'll fix it soon.

nicholascarroll commented 1 month ago

OK fixed!

japanoise commented 1 month ago

Fantastic, thank you!