adapted to master changes

japaric-archived / linalg.rs

[INACTIVE]

Apache License 2.0

29 stars 1 forks source link

Closed flying-sheep closed 9 years ago

flying-sheep commented 9 years ago

dunno if there’s better options than .collect::<Vec<T>>().into_boxed_slice()

flying-sheep commented 9 years ago

needs BurntSushi/quickcheck#50 to build

japaric commented 9 years ago

Changes look good to me, let's wait until quickcheck is working again, before merging this.

flying-sheep commented 9 years ago

huh? did you change complex.rs or were there yet more master changes?

/edit: more master changes! Add<RHS, Result> → Add<RHS = Self>

japaric commented 9 years ago

More assoc types stuff landed. I think it already got in the nightlies.

flying-sheep commented 9 years ago

yeah, ~~damn~~. i’ll update then fix it.

i really shouldn’t be frustrated that’s what i get for not waiting a few months until rust is stable ;)

(and those changes are really good looking)

flying-sheep commented 9 years ago

ok, once japaric/complex.rs#9 is merged, i’ll update this project’s use of Add/Mul/…

or you could merge this and i’ll do another PR with the other changes?

japaric commented 9 years ago

@flying-sheep either way is fine, I'll let you pick ;-)

flying-sheep commented 9 years ago

well, if you don’t squash commits, the history will be pretty after merging all at once, so why not do it like that!

flying-sheep commented 9 years ago

wait. check_line_lengths.sh makes the build fail? i’m calling bullshit ;)

japaric commented 9 years ago

:100:

flying-sheep commented 9 years ago

woo! outraced master! :yum: