search

japaric / f3

Board Support Crate for the STM32F3DISCOVERY
Apache License 2.0
94 stars 35 forks source link

Implemented the embedded_serial traits. #74

Closed thejpster closed 6 years ago

thejpster commented 7 years ago

I've implemented the embedded serial traits we talked about during novemb.rs. Untested, as I don't have a F3 Discovery...

japaric commented 7 years ago

Thanks for the PR, @thejpster. Unfortunately the serial::Port struct is not public and thus it's not exposed as part of the API so users won't be able to use these traits even if we implement them for serial::Port. :-/

However, an interesting experiment would be implementing these traits for the future based serial API in #52 to provide a more ergonomic blocking API.

homunkulus commented 7 years ago

:umbrella: The latest upstream changes (presumably e2fecfb) made this pull request unmergeable. Please resolve the merge conflicts.

japaric commented 6 years ago

I believe this no longer applies now that we have embedded-hal.