japaric / steed

[INACTIVE] Rust's standard library, free of C dependencies, for Linux systems
519 stars 22 forks source link

fix unit tests #115

Open japaric opened 7 years ago

japaric commented 7 years ago
japaric commented 7 years ago

updated cc @tbu-

tbu- commented 7 years ago

Thanks, being able to run the test suite is great!

Looks like quite a bit could be gained by implementing env. What's the state of #72?

japaric commented 7 years ago

@tbu- It breaks the powerpc (iirc?) target but works everywhere else. Wasn't sure if it was ok to drop support for one target ...

japaric commented 7 years ago

or to be more specific, the startup (before main) stuff of the powepc target is already flaky. #72 requires doing more startup stuff which finishes breaking the powerpc target :-)

tbu- commented 7 years ago

In what context is the execution of the unit tests? It seems that std::rt::start is not executed when trying to cross test.

japaric commented 7 years ago

In what context is the execution of the unit tests?

rustc will insert a vanilla main function into the library crate turning it into a binary crate so the test runner should behave like a normal program and execute _start and then std::rt::start and then main.

tbu- commented 7 years ago

Mh. It didn't print when I inserted a println! into the std::rt::start function.

japaric commented 7 years ago

@tbu- I have sent you an invite to become a collaborator of this repo :tada:. Could you check off the tests that have been fixed in the issue description?

tbu- commented 7 years ago

Thank you. Did that.