search

japaric / stm32f103xx-hal

HAL for the STM32F103xx family of microcontrollers
Apache License 2.0
115 stars 40 forks source link

WIP: edition 2018 #115

Closed burrbull closed 5 years ago

burrbull commented 5 years ago

Make crate compatible with Rust 1.31 beta and "Edition 2018"

burrbull commented 5 years ago

Waiting for #https://github.com/japaric/stm32f103xx/pull/27 to be merged.

burrbull commented 5 years ago

update stm32f103xx to 0.11-alpha.1 revert jnet version @therealprof

TeXitoi commented 5 years ago

Compiling on beta \o/ https://travis-ci.org/TeXitoi/rusty-clock/jobs/464411252

I don't have the hardware here, I'll try as soon as possible.

TeXitoi commented 5 years ago

working on stable \o/

TeXitoi commented 5 years ago

stm32f103xx v0.11.0 is out, only waiting for rtfm 0.4

TeXitoi commented 5 years ago

I think we can merge this with the update to stm32f103xx v0.11.0. depending on the beta rtfm is OK as it is a dev dependency.

burrbull commented 5 years ago

Done.

TeXitoi commented 5 years ago

@therealprof OK to merge?

therealprof commented 5 years ago

@TeXitoi Depending on a beta is fine for this crate since it's not published on crates.io anyway. Actually I prefer to do it rather sooner than later since I'm in the process of generalising this HAL impl.

TeXitoi commented 5 years ago

@therealprof As you have requested changes, I let you dismiss your review or approve and merge, as you wish.