japaric / trust

Travis CI and AppVeyor template to test your Rust crate on 5 architectures and publish binary releases of it for Linux, macOS and Windows
Apache License 2.0
1.26k stars 59 forks source link

Drop need for SUDO for faster Travis scheduling #48

Closed fenollp closed 7 years ago

fenollp commented 7 years ago

Well it seems the sudo setting is set by TravisCI from the services: docker thing. I can either

  1. revert last commit and squash
  2. close this PR

you decide :)

japaric commented 7 years ago

Can you do sudo apt-get .. if you drop sudo: required? I have a vague recollection of trying something like that and that sudo couldn't be used. I may be misremembering though.

fenollp commented 7 years ago

Ah you're saying this works because the cache saves the day? In any case since this PR doesn't seem to make the jobs run on the Travis Docker workers, it can be closed. But maybe they do run on the docker workers? I'm not sure.

japaric commented 7 years ago

In any case since this PR doesn't seem to make the jobs run on the Travis Docker workers, it can be closed

OK. Let's better leave this as it is then.