search

japaric / ufmt

a smaller, faster and panic-free alternative to core::fmt
Apache License 2.0
352 stars 40 forks source link

Remove dependency on `proc-macro-hack` #34

Closed davidcole1340 closed 2 years ago

davidcole1340 commented 2 years ago

Has not been required since Rust 1.45. For legacy support, ufmt will still use proc-macro-hack when the legacy feature is enabled (by default). Users on later Rust versions can disable it by disabling default features.

davidcole1340 commented 2 years ago

I changed it to disable proc-macro-hack by default. Can revert if required.

japaric commented 2 years ago

Thanks for the PR.

Has not been required since Rust 1.45.

the MSRV of the ufmt crate is 1.34 so this cannot be added as an opt-in feature; it would need to be opt-out which makes next to impossible to turn off in practice due to how Cargo features are resolved.

I'd prefer to wait for a new minor release (0.2) and drop both the MSRV and proc-macro-hack