search

japgolly / scalajs-react

Facebook's React on Scala.JS
https://japgolly.github.io/scalajs-react/
Apache License 2.0
1.64k stars 231 forks source link

Add react key to SVG attributes #1059

Closed triggerNZ closed 2 years ago

triggerNZ commented 2 years ago

key was missing from SVG attributes, requiring users to use the HTML one, which is a bit awkward.

japgolly commented 2 years ago

Hey man, sorry for delay. Caught covid, was completely fucked all of last week. Only finally out of bed for a day or so.

CI is running now but I'll bet ya a round (🍺) it's gonna complain...

japgolly commented 2 years ago

Oh dammit I guess I owe you a 🍺, HtmlTags and SvgTags aren't composed anywhere it seems, was expecting a failure due to conflicting final val key instances. Alright, in it goes...

japgolly commented 2 years ago

v2.1.1 released with this fix

japgolly commented 1 year ago

Hey man. Ack but I'm sick with covid atm, gimme another day or two.

On Mon, 18 Apr 2022, 7:44 pm Tin Pavlinic, @.***> wrote:

key was missing from SVG attributes, requiring users to use the HTML one, which is a bit awkward.

You can view, comment on, or merge this pull request online at:

https://github.com/japgolly/scalajs-react/pull/1059 Commit Summary

File Changes

(1 file https://github.com/japgolly/scalajs-react/pull/1059/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/japgolly/scalajs-react/pull/1059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRRN2NZ3YGYWUPTHM7HTDVFUVHDANCNFSM5TVOI4TQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>