search

japgolly / scalajs-react

Facebook's React on Scala.JS
https://japgolly.github.io/scalajs-react/
Apache License 2.0
1.64k stars 231 forks source link

Point at library subfolder #1083

Closed dispalt closed 1 year ago

dispalt commented 1 year ago

When everything moved to the subdirectory I think it broke the mapping, I was playing around with something and just noticed it stopped correctly mapping sources.

nkgm commented 1 year ago

+1 Also discussed in #1081

dispalt commented 1 year ago

Thoughts @japgolly ?

cquiroz commented 1 year ago

It seems this should be fine. Did you publish locally to test?

dispalt commented 1 year ago

No, I will do that and report back here

dispalt commented 1 year ago

Okay tested it end to end, and glad I did because I had the version and prefix flipped. It looks good now though.

cquiroz commented 1 year ago

Cool, thanks a lot. Could you a add a little not on the changelog?

dispalt commented 1 year ago

Done

cquiroz commented 1 year ago

Thanks a lot @dispalt