japgolly / scalajs-react

Facebook's React on Scala.JS
https://japgolly.github.io/scalajs-react/
Apache License 2.0
1.64k stars 231 forks source link

Standardizing on Cats? #345

Closed a1russell closed 7 years ago

a1russell commented 7 years ago

Since 1.0.0 hasn't quite been released yet, I'm wondering whether we can discuss standardizing on Cats rather than Scalaz.

As evidenced by the recently announced joint effort by popular libraries doobie, http4s, and Matryoshka, Cats is gaining momentum versus Scalaz.

In fact, I've personally avoided using scalajs-react in the past in part because of the Scalaz dependency/association.

I'm curious whether you might consider moving to Cats instead.

japgolly commented 7 years ago

Hi @a1russell, scalajs-react doesn't have a dependency on Scalaz, although it used to a long, long time ago. Now it has an optional extension module that provides Scalaz support but neither core, test or extra use it.

Users are free to use the Scalaz module, the Cats module, neither or both. :)

Does that address your query?

a1russell commented 7 years ago

Oh! Is it just the tests that depend on it, then? I saw Scalaz in the build file and guess I did not read it thoroughly enough.

japgolly commented 7 years ago

Well it's a bit unconventional but only the tests of the test module do (whaat?); the actual test module that gets exported doesn't depend on it (hoorah!).

a1russell commented 7 years ago

Ah, okay, hah.

I was excited to see #341 get merged. Will it be ported to the neo branch, as well?

japgolly commented 7 years ago

The neo branch became 1.0.0-RC1 which was merged into master. Master is the new neo branch now so in that sense, yes; done! In fact it's been released already too because it was part of 1.0.0-RC2.

a1russell commented 7 years ago

Oh, I understand now. That's great! Closing this.

japgolly commented 7 years ago

No worries; cheers!

On 25 March 2017 at 08:42, Adam Russell notifications@github.com wrote:

Oh, I understand now. That's great! Closing this.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/japgolly/scalajs-react/issues/345#issuecomment-289150255, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMYt3sSZ680iVfYrC-j8Mfp4nMtgvYaks5rpDjggaJpZM4MotEk .