jaqobb / message-editor

Spigot plugin that allows editing in-game messages that were previously unmodifiable
MIT License
13 stars 2 forks source link

No GUI #37

Closed mllr-mx closed 1 year ago

mllr-mx commented 1 year ago

Hi, I have tested your plugin. Unfortunately it does not work as presented. I can't click on any messages to get into the GUI. I tried with 2.5.0., 2.5.1. and 2.5.2. snapshot. I am at the current PaperMC version (#445) with ProtocolLib v5.0.0-SNAPSHOT-b612. The commands are displayed to me. But unfortunately no hover. Any ideas?

jaqobb commented 1 year ago

Hello,

Let's start with first making sure these are true:

If there are still no hover messages, try using /messageeditor activate game_chat system_chat and check whether your messages are being correctly analyzed in the console (0:00 and 0:30 - 0:40 respectively, tutorial available here: https://www.youtube.com/watch?v=tUDvZOxwlok).

mllr-mx commented 1 year ago

> There are no errors in the console No Errors, the plugin is loading with no problems:

[13:35:14] [Server thread/INFO]: [MessageEditor] Enabling MessageEditor v2.5.1 [13:35:14] [Server thread/INFO]: [MessageEditor] Starting updater... [13:35:14] [Server thread/INFO]: [MessageEditor] Starting menu manager... [13:35:14] [Server thread/INFO]: [MessageEditor] Registering command... [13:35:14] [Server thread/INFO]: [MessageEditor] Registering listeners... [13:35:14] [Server thread/INFO]: [MessageEditor] Registering packet listeners...

> attach-special-hover-and-click-events setting in config.yml is set to true > packet-listeners.chat setting in config.yml is set to true Yes, both are true.

> You have messageeditor.use permission In Luckperms I have assigned the permissives to my player. And the player also still has OP rights.

_> If there are still no hover messages, try using /messageeditor activate game_chat systemchat and check whether your messages are being correctly analyzed in the console Only the executed command is displayed in the console. [13:38:51 INFO]: m291 issued server command: /messageeditor activate GAME_CHAT SYSTEM_CHAT In the game itself also says: [Message Editor] You have activated analyzing 2 message place(s).

But no hover or gui-menu.

jaqobb commented 1 year ago

Alright, then just in case let's also verify whether the default edits work in the first place, that would be player join message and messages after using the /version command. You can view the default edits in the edits directory.

mllr-mx commented 1 year ago

I have the defaults in, but the new variant of the "join" does not work. But the new variant of "version" works. Here the last line is green.

jaqobb commented 1 year ago

I see. This makes it kind of hard to pinpoint the exact problem. Could you send your plugin list? You might have a plugin that changes the join message and also interacts with chat messages.

mllr-mx commented 1 year ago

I had already thought that and had accordingly deleted all plugins, except Luckperms. But the symptoms have been the same.

mllr-mx commented 1 year ago

If I read correctly, you already had it running under 1.19.3. There were only problems with Entity_Name. Do you remember which versions of PaperMC and ProtocolLib you had? Then I would start fresh and update successively until I found the error.

jaqobb commented 1 year ago

My current test server on which I confirmed the plugin working as intended runs on Spigot (not Paper) 3626 and ProtocolLib v5.0.0-SNAPSHOT-b608 which now makes me think that Paper might be the one breaking the plugin.

mllr-mx commented 1 year ago

I have tested it now. It's up to Paper. It looks like Paper is blocking some of it. There is also nothing in the config that affects it. With Spigot it worked immediately.

jaqobb commented 1 year ago

I see. In such case, I recommend using Spigot for the time being or waiting for an update. I feel like I might know the reason behind Paper breaking the plugin but I'll have to investigate it later to confirm.

mllr-mx commented 1 year ago

I hope it is only a small correction and it finally works on paper. I would be very happy and would then also send you a donation.

jaqobb commented 1 year ago

I have investigated the issue and found out the cause being adventure that Paper uses for its UI library.

Unfortunately, the changes that adventure makes are big and it would take some time to make Message Editor support Paper and due to my limited time, I am currently unable to create an update in a reasonable amount of time.

However, I will keep this issue open for the time being and hopefully revisit it once 1.20 is released.

jaqobb commented 1 year ago

Message Editor 2.5.2 has been released, fixing Paper issue and bumping ProtocolLib API among other things.