jaquadro / StorageDrawers

A mod adding compartmental storage for Minecraft Forge
MIT License
192 stars 153 forks source link

[1.10.2]Compacting Drawer #310

Open Tempus-Dominus opened 8 years ago

Tempus-Dominus commented 8 years ago

The compacting drawer is not compacting things like red sand, diorite, granite, andesite and stone into their crafted forms of red sandstone, polished diorite, polished granite, polished andesite and stone bricks.

jaquadro commented 8 years ago

It's not supposed to, because there aren't recipes to craft them back.

In 1.7.10 you'd override this in MineTweaker, but there's no equivalent support in 1.10.2 right now.

ntwitch commented 8 years ago

These are compactible but have no return recipes: Nether Quartz -> Block of Quartz -> Nether Quartz Brick -> Bricks -> Brick Nether Brick -> Nether Brick (Block) -> Nether Brick Sand -> Sandstone -> Sand

Compactible and the return method is breaking in world: Clay -> Clay (Block) -> Clay Snowball -> Snow -> Snowball Melon -> Melon (Block) -> Melon Glowstone Dust -> Glowstone -> Glowstone Dust (Melon and Glowstone require a Fortune III tool to guarantee getting back the full amount)

It might be worth it to add a "compactible" list to the config, so as to not rely on another mod for customization.

AuoroP commented 7 years ago

I was heart-broken to discover compacting drawers don't work with logs and planks; planks are my filler block... If you think about it, a compacting drawer should be the perfect place to store logs and planks. I am not having the best day so you have to convince yourself this is a Storage Drawer design oversight.

Added after sleeping on it: I slept on it and I'm even more convinced compacting logs and planks should be an option. I'd really suggest starting a tree farm in FTB Ultimate Lite1.10 test world: peaceful survival with bonus chest.

jaquadro commented 7 years ago

As of 3.4.6, I have added native configuration for the stuff that was previously only possible by MineTweaker, which includes changing the compacting tiers. To get the planks/logs, change the registries section of the config file with this:

    S:compactingRules <
        minecraft:log:0, minecraft:planks:0, 4
        minecraft:log:1, minecraft:planks:1, 4
        minecraft:log:2, minecraft:planks:2, 4
        minecraft:log:3, minecraft:planks:3, 4
        minecraft:log2:0, minecraft:planks:4, 4
        minecraft:log2:1, minecraft:planks:5, 4
     >

If you want to support logs added by other mods, you'll have to do some legwork to find their corresponding names and metadata values and pair them up. If someone does the work and would like to share it, I could add a wiki page for it.

uecasm commented 7 years ago

@jaquadro Not sure what caused it (best guess: a bug in a prior TiCon version?), but for some reason all of my iron ingots had an empty "tag" NBT value, and this caused Storage Drawers 1.10.2-3.5.8 to treat them strangely. In particular they'd go into the top slot of a Compacting Drawer with no other types, and if I crafted some of them into an iron block, it would go in the top (showing ingots-nuggets as well) but not accept more such ingots.

However I could pull ingots or nuggets out and put them back in, or craft the original ingots into blocks or nuggets and put those in -- these didn't have the tag property at all. I don't know if this technically counts as a bug (since the two kinds of ingots don't stack together in the inventory either), but crafting does treat them identically, so perhaps an empty tag could be considered the same as no tag?

uecasm commented 7 years ago

Also:

Type Rule
Oak minecraft:log:0, minecraft:planks:0, 4
Spruce minecraft:log:1, minecraft:planks:1, 4
Birch minecraft:log:2, minecraft:planks:2, 4
Jungle minecraft:log:3, minecraft:planks:3, 4
Acacia minecraft:log2:0, minecraft:planks:4, 4
Dark Oak minecraft:log2:1, minecraft:planks:5, 4
Sacred Oak biomesoplenty:log_0:4, biomesoplenty:planks_0:0, 4
Cherry biomesoplenty:log_0:5, biomesoplenty:planks_0:1, 4
Umbran biomesoplenty:log_0:6, biomesoplenty:planks_0:2, 4
Fir biomesoplenty:log_0:7, biomesoplenty:planks_0:3, 4
Ethereal biomesoplenty:log_1:4, biomesoplenty:planks_0:4, 4
Magic biomesoplenty:log_1:5, biomesoplenty:planks_0:5, 4
Mangrove biomesoplenty:log_1:6, biomesoplenty:planks_0:6, 4
Palm biomesoplenty:log_1:7, biomesoplenty:planks_0:7, 4
Redwood biomesoplenty:log_2:4, biomesoplenty:planks_0:8, 4
Willow biomesoplenty:log_2:5, biomesoplenty:planks_0:9, 4
Pine biomesoplenty:log_2:6, biomesoplenty:planks_0:10, 4
Hellbark biomesoplenty:log_2:7, biomesoplenty:planks_0:11, 4
Jacaranda biomesoplenty:log_3:4, biomesoplenty:planks_0:12, 4
Mahogany biomesoplenty:log_3:5, biomesoplenty:planks_0:13, 4
Ebony biomesoplenty:log_3:6, biomesoplenty:planks_0:14, 4
Eucalyptus biomesoplenty:log_3:7, biomesoplenty:planks_0:15, 4
Livingwood botania:livingwood:0, botania:livingwood:1, 4
Larch forestry:logs.0:0, forestry:planks.0:0, 4
Teak forestry:logs.0:1, forestry:planks.0:1, 4
Desert Acacia forestry:logs.0:2, forestry:planks.0:2, 4
Lime forestry:logs.0:3, forestry:planks.0:3, 4
Chestnut forestry:logs.1:0, forestry:planks.0:4, 4
Wenge forestry:logs.1:1, forestry:planks.0:5, 4
Baobab forestry:logs.1:2, forestry:planks.0:6, 4
Sequoia forestry:logs.1:3, forestry:planks.0:7, 4
Kapok forestry:logs.2:0, forestry:planks.0:8, 4
Ebony forestry:logs.2:1, forestry:planks.0:9, 4
Mahogany forestry:logs.2:2, forestry:planks.0:10, 4
Balsa forestry:logs.2:3, forestry:planks.0:11, 4
Willow forestry:logs.3:0, forestry:planks.0:12, 4
Walnut forestry:logs.3:1, forestry:planks.0:13, 4
Greenheart forestry:logs.3:2, forestry:planks.0:14, 4
Cherry forestry:logs.3:3, forestry:planks.0:15, 4
Mahoe forestry:logs.4:0, forestry:planks.1:0, 4
Poplar forestry:logs.4:1, forestry:planks.1:1, 4
Palm forestry:logs.4:2, forestry:planks.1:2, 4
Papaya forestry:logs.4:3, forestry:planks.1:3, 4
Pine forestry:logs.5:0, forestry:planks.1:4, 4
Plum forestry:logs.5:1, forestry:planks.1:5, 4
Maple forestry:logs.5:2, forestry:planks.1:6, 4
Citrus forestry:logs.5:3, forestry:planks.1:7, 4
Giant Sequoia forestry:logs.6:0, forestry:planks.1:8, 4
Ipe forestry:logs.6:1, forestry:planks.1:9, 4
Padauk forestry:logs.6:2, forestry:planks.1:10, 4
Cocobolo forestry:logs.6:3, forestry:planks.1:11, 4
Zebrawood forestry:logs.7:0, forestry:planks.1:12, 4
... there's also fireproof versions of all the Forestry and Vanilla woods; I won't list those here

I haven't explicitly verified these as Storage Drawers rules, but I think they're all correct.