jaquadro / StorageDrawers

A mod adding compartmental storage for Minecraft Forge
MIT License
196 stars 155 forks source link

[Request] Thaumcraft Golem Support #77

Closed TehNut closed 9 years ago

TehNut commented 9 years ago

From my testing, it seems that TC Golems cannot interact with Storage Drawers inventories at all. It would be nice if they could do so.

If I missed this support somewhere, I apologize.

codewarrior0 commented 9 years ago

Golems can work with drawers, but there's a gotcha.

You can't click on the front of the drawer with the bell. You need to do it on any other side. Same for the drawer controller.

This is probably a minor bug, but I don't know if it's TC's or SD's fault. There's a related bug where you try to put a bell into a drawer: the drawer shows the bell icon, but the bell stays in your hand.

TehNut commented 9 years ago

Huh... Odd. That also solves my issue with the Super Crafting Frame.

jaquadro commented 9 years ago

This might have something to do with the front face not being considered valid for inventory input/output. It made complete sense for pipes, but maybe not so much for those two. I could lift the restriction.

Not sure about that other bell thing codewarrior mentioned.

codewarrior0 commented 9 years ago

It might be the general case of trying to put an item with a right-click ability into a drawer. You simply can't put a drawer key or a drawer upgrade into a drawer, and trying to put a Chisel into a drawer crashes to the title screen.

jaquadro commented 9 years ago

You can, if you sneak. Otherwise you have two item handlers trying to invoke special behavior on the same click event.

There's two separate sets of interfaces for manipulating drawer inventories. There's the IDrawer collection of interfaces, which manages full-size slots and deals with the controller and interactive input/output through the front face. Then there's the standard IInventory collection of interfaces, which the rest of the Minecraft world works with - including I assume SFCs and Golems. It's there that there's an artificial restriction on the front face.

codewarrior0 commented 9 years ago

Then we may have a bug here with somebody's right-click handler. This is what happens when right-clicking on a drawer with and without shift.

(Using 1.4.0... haven't updated yet)

jaquadro commented 9 years ago

I'm probably wrong about the sneak insert bit then. Probably confusing it with being able to insert an upgrade after the same upgrade is already applied. Bell thing is plain weird.

codewarrior0 commented 9 years ago

Oh, I didn't try inserting an already applied upgrade. Here we go.

When the same upgrade is already applied, right-clicking without shift inserts the upgrade. With shift, nothing.

jaquadro commented 9 years ago

Give 1.4.4 a try, tell me if it solves your issues with SFC and Golems.

TehNut commented 9 years ago

Yes that seems to have fixed both issues. Thank you very much!