jaquadro / StorageDrawers

A mod adding compartmental storage for Minecraft Forge
MIT License
195 stars 153 forks source link

Conversion Upgrade isn't working #913

Open DanteAyagawe opened 3 years ago

DanteAyagawe commented 3 years ago

There's an issue I've been having with the Auto-convert item, because as I place a different type of ingot and then another in a compacting drawer with the auto-convert upgrade, it doesn't auto convert the other to the other. I was searching this issue myself and got myself nowhere, I also checked the config file and didn't see anything about manually doing the auto-convert code myself, so yeah I'm really at a lost here.

The version is 1.16.4 and the drawer mod is the most updated ;-; halp

Credit-Score commented 3 years ago

I'm also having this issue and I would love to have it fixed, I have no way I know of to ore-dictionary convert items.

AwesmePersn commented 3 years ago

Playing the Direwolf20 1.16 pack and ran into this issue myself. Tetra Geodes currently gives different versions of different nuggets. The only way I've found to resolve this is to manually craft them into ingots as I also tried the conversion upgrade and found it didn't work. The ingot recipe works, but the conversion upgrade does not. Compacting drawers were useful for this.

ecksfiftyone commented 3 years ago

Same issue. Conversion upgrade is in place but mekanism and tinkers copper are not converting.

CodeGordon commented 3 years ago

Same issue as above with Tinker's, Thermal, and Mekanism installed, which add some of the same metals. Most notably copper, lead, tin, and bronze.

Minecraft 1.16.5 Forge 36.2.2 Storage Drawers 8.3.0 Tinker's Construct 3.1.1.252 Thermal Foundation 1.3.2 Mekanism 10.0.21.448

CodeGordon commented 3 years ago

The conversion upgrade is being checked for...

https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/UpgradeData.java#L180-L199 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/UpgradeData.java#L148-L150 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/capabilities/BasicDrawerAttributes.java#L120-L133

...but this isn't actually doing anything in practice.

https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/util/ItemStackOreMatcher.java#L1-L12 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/StandardDrawerGroup.java#L200-L203 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/FractionalDrawerGroup.java#L414-L425 https://github.com/jaquadro/StorageDrawers/blob/99c733e96a0a48141f67b9b9c4da466f0e718769/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/FractionalDrawerGroup.java#L471-L478

Functionality for this upgrade is disabled, and apparently has been for a long time.

ghost commented 2 years ago

up

CodeGordon commented 2 years ago

It's been the better part of a year and nothing has happened on this issue at all.

DanteAyagawe commented 2 years ago

It's been the better part of a year and nothing has happened on this issue at all.

oof... I gave up on the upgrade and just went for alternatives, but damn this would be fucking useful ;-;

zoller27osu commented 2 years ago

@jaquadro you should probably either fix this or disable the conversion upgrade completely. In it's current state it's very misleading.

ALainxD commented 2 years ago

Include the conversion upgrade in the compacting drawers recipe or remove it please, I litteraly googled for 20mins what this upgrade does

EgorIII commented 2 years ago

bump

ThatBlockyPenguin commented 2 years ago

also bump

kurobara31694 commented 2 years ago

bump

Thedeur commented 2 years ago

Bump

CodeGordon commented 2 years ago

A year and a half of nothing from the mod author isn't very encouraging.

DevMunky commented 1 year ago

this is a dumb issue, shouldnt be one and is a really easy fix. just remove it and stop misleading people