jaraco
commented
1 year ago Additionally, tests fail around font checks:
```
cssutils main $ tox -- -p no:cov -k test_validateWithProfile_fonts -v --runxfail
.pkg: _optional_hooks> python /Users/jaraco/.local/pipx/venvs/tox/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: get_requires_for_build_editable> python /Users/jaraco/.local/pipx/venvs/tox/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: build_editable> python /Users/jaraco/.local/pipx/venvs/tox/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta
py: install_package> python -I -m pip install --force-reinstall --no-deps .tox/.tmp/package/94/cssutils-2.7.2.dev7+g0dfc5f7c.d20230612-0.editable-py3-none-any.whl
py: commands[0]> pytest -p no:cov -k test_validateWithProfile_fonts -v --runxfail
/Users/jaraco/code/jaraco/cssutils/.tox/py/lib/python3.11/site-packages/_pytest/faulthandler.py:30: EncodingWarning: 'encoding' argument not specified
config.stash[fault_handler_stderr_key] = open(stderr_fd_copy, "w")
============================================================= test session starts ==============================================================
platform darwin -- Python 3.11.3, pytest-7.3.1, pluggy-1.0.0 -- /Users/jaraco/code/jaraco/cssutils/.tox/py/bin/python
cachedir: .tox/py/.pytest_cache
rootdir: /Users/jaraco/code/jaraco/cssutils
configfile: pytest.ini
plugins: black-0.3.12, enabler-2.1.1, mypy-0.10.3, ruff-0.1, jaraco.test-5.3.0, checkdocs-2.9.0
collected 621 items / 615 deselected / 6 selected
cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params0-results0] FAILED [ 20%]
cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params1-results1] FAILED [ 40%]
cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params2-results2] FAILED [ 60%]
cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params3-results3] FAILED [ 80%]
cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params4-results4] FAILED [100%]
=================================================================== FAILURES ===================================================================
________________________________________ TestProfiles.test_validateWithProfile_fonts[params0-results0] _________________________________________
self =
params = (('CSS Fonts Module Level 3 @font-face properties',), 'font-family', ('y', '"y"'))
results = (True, True, ('CSS Fonts Module Level 3 @font-face properties',))
@pytest.mark.parametrize(('params', 'results'), _gen_validation_inputs())
@pytest.mark.xfail(reason="#37")
def test_validateWithProfile_fonts(self, params, results):
"Profiles.validateWithProfile()"
# testing for valid values overwritten in a profile
v, m, p = results
expected = v, m, list(p)
> assert cssutils.profile.validateWithProfile(*params) == expected
E AssertionError: assert (False, False, []) == (True, True, ... properties'])
E At index 0 diff: False != True
E Full diff:
E - (True, True, ['CSS Fonts Module Level 3 @font-face properties'])
E + (False, False, [])
cssutils/tests/test_profiles.py:743: AssertionError
________________________________________ TestProfiles.test_validateWithProfile_fonts[params1-results1] _________________________________________
self =
params = (('CSS Fonts Module Level 3 @font-face properties',), 'font-family', ('"y", "a"', 'a, b', 'a a'))
results = (True, False, ('CSS Level 2.1',))
@pytest.mark.parametrize(('params', 'results'), _gen_validation_inputs())
@pytest.mark.xfail(reason="#37")
def test_validateWithProfile_fonts(self, params, results):
"Profiles.validateWithProfile()"
# testing for valid values overwritten in a profile
v, m, p = results
expected = v, m, list(p)
> assert cssutils.profile.validateWithProfile(*params) == expected
E AssertionError: assert (False, False, []) == (True, False,...S Level 2.1'])
E At index 0 diff: False != True
E Full diff:
E - (True, False, ['CSS Level 2.1'])
E + (False, False, [])
cssutils/tests/test_profiles.py:743: AssertionError
________________________________________ TestProfiles.test_validateWithProfile_fonts[params2-results2] _________________________________________
self =
params = (('CSS Fonts Module Level 3 @font-face properties',), 'font-stretch', ('normal', 'wider', 'narrower', 'inherit'))
results = (True, False, ('CSS Fonts Module Level 3',))
@pytest.mark.parametrize(('params', 'results'), _gen_validation_inputs())
@pytest.mark.xfail(reason="#37")
def test_validateWithProfile_fonts(self, params, results):
"Profiles.validateWithProfile()"
# testing for valid values overwritten in a profile
v, m, p = results
expected = v, m, list(p)
> assert cssutils.profile.validateWithProfile(*params) == expected
E AssertionError: assert (False, False, []) == (True, False,...ule Level 3'])
E At index 0 diff: False != True
E Full diff:
E - (True, False, ['CSS Fonts Module Level 3'])
E + (False, False, [])
cssutils/tests/test_profiles.py:743: AssertionError
________________________________________ TestProfiles.test_validateWithProfile_fonts[params3-results3] _________________________________________
self =
params = (('CSS Fonts Module Level 3 @font-face properties',), 'font-style', ('inherit',)), results = (True, False, ('CSS Level 2.1',))
@pytest.mark.parametrize(('params', 'results'), _gen_validation_inputs())
@pytest.mark.xfail(reason="#37")
def test_validateWithProfile_fonts(self, params, results):
"Profiles.validateWithProfile()"
# testing for valid values overwritten in a profile
v, m, p = results
expected = v, m, list(p)
> assert cssutils.profile.validateWithProfile(*params) == expected
E AssertionError: assert (False, False, []) == (True, False,...S Level 2.1'])
E At index 0 diff: False != True
E Full diff:
E - (True, False, ['CSS Level 2.1'])
E + (False, False, [])
cssutils/tests/test_profiles.py:743: AssertionError
________________________________________ TestProfiles.test_validateWithProfile_fonts[params4-results4] _________________________________________
self =
params = (('CSS Fonts Module Level 3 @font-face properties',), 'font-weight', ('bolder', 'lighter', 'inherit'))
results = (True, False, ('CSS Level 2.1',))
@pytest.mark.parametrize(('params', 'results'), _gen_validation_inputs())
@pytest.mark.xfail(reason="#37")
def test_validateWithProfile_fonts(self, params, results):
"Profiles.validateWithProfile()"
# testing for valid values overwritten in a profile
v, m, p = results
expected = v, m, list(p)
> assert cssutils.profile.validateWithProfile(*params) == expected
E AssertionError: assert (False, False, []) == (True, False,...S Level 2.1'])
E At index 0 diff: False != True
E Full diff:
E - (True, False, ['CSS Level 2.1'])
E + (False, False, [])
cssutils/tests/test_profiles.py:743: AssertionError
=========================================================== short test summary info ============================================================
FAILED cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params0-results0] - AssertionError: assert (False, False, []) == (True, True, ... properties'])
FAILED cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params1-results1] - AssertionError: assert (False, False, []) == (True, False,...S Level 2.1'])
FAILED cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params2-results2] - AssertionError: assert (False, False, []) == (True, False,...ule Level 3'])
FAILED cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params3-results3] - AssertionError: assert (False, False, []) == (True, False,...S Level 2.1'])
FAILED cssutils/tests/test_profiles.py::TestProfiles::test_validateWithProfile_fonts[params4-results4] - AssertionError: assert (False, False, []) == (True, False,...S Level 2.1'])
====================================================== 5 failed, 615 deselected in 0.38s =======================================================
py: exit 1 (0.58 seconds) /Users/jaraco/code/jaraco/cssutils> pytest -p no:cov -k test_validateWithProfile_fonts -v --runxfail pid=36421
.pkg: _exit> python /Users/jaraco/.local/pipx/venvs/tox/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta
py: FAIL code 1 (1.42=setup[0.83]+cmd[0.58] seconds)
evaluation failed :( (1.47 seconds)
```
Several variants of
test_validateWithProfileare failing to meet expectations:Someone should investigate and ascertain if those tests are meaningful and if something should be corrected or if those tests should be removed.