search

jaraco / inflect

Correctly generate plurals, ordinals, indefinite articles; convert numbers to words
https://pypi.org/project/inflect
MIT License
957 stars 107 forks source link

Cleanup mini-project: test methods, package complexity #174

Closed jayaddison closed 1 year ago

jayaddison commented 1 year ago

A mixture of small cleanups for warnings reported by pytest, pylint and flake8.

Vaguely relates-to / inspired-by #122, although doesn't yet resolve that in anything approaching a comprehensive way.

jayaddison commented 1 year ago

(the unwritten subtext about these changes is that I think that my contributions in #95 - while useful in the context of the openculinary organization that I work for - was dubiously-architected and perhaps disruptive or annoying, as seems evident to me from some of the discussion (it was relatively early into my 'working in open source' journey, and hopefully I've learned a few things since then). I'd like to try to make amends for some of that by providing more than the equivalent offerings in terms of cleanup and simplification, if possible)

jayaddison commented 1 year ago

Although I think that some of the cleanups here are valid, the branch now contains a mixture of changes to unrelated parts of the code. I'm not going to make any radical changes yet, but am beginning to think about alternative ways to present the changes for review.

jayaddison commented 1 year ago

Todo: return to cherry-pick and individually open pull requests for some of the refactors contained in this branch.