jaraco / inflect

Correctly generate plurals, ordinals, indefinite articles; convert numbers to words
https://pypi.org/project/inflect
MIT License
957 stars 107 forks source link

inflect/__init__.py::inflect.engine.compare test fails with pydantic-core >= 2.12 #204

Closed jhatler closed 5 months ago

jhatler commented 8 months ago

The below PR on pydantic-core introduced a change to the validation error messages which breaks the inflect/init.py::inflect.engine.compare test.

https://github.com/pydantic/pydantic-core/pull/1050

The test breaks because the error message defined at the below line is plural when the number "1" is used, which is grammatically incorrect.

https://github.com/jaraco/inflect/blob/eff29a4177d5c5dedf88617b7c60d7a6679c440e/inflect/__init__.py#L2469

jaraco commented 5 months ago

Thanks for the report and the pull request. I addressed the issue in 5ef0baba20bb7c6ebd9b6cb0bda73ba0873fef9f.