search

jaraco / inflect

Correctly generate plurals, ordinals, indefinite articles; convert numbers to words
https://pypi.org/project/inflect
MIT License
969 stars 106 forks source link

fix: compare validation now expects singular noun #205

Closed jhatler closed 7 months ago

jhatler commented 10 months ago

On pydantic-code >= 2.12, the validation error messages use the singular of the word "character" when the number 1 is specified in a condition. This breaks the engine.compare validation, which expected the plural.

Refs: #204 Signed-off-by: Jaremy Hatler hatler.jaremy@gmail.com

jhatler commented 10 months ago

I tested this as part of https://github.com/jhatler/inflect/pull/1 by running the tests in the main.yml workflow on my fork.

jaraco commented 7 months ago

Thanks for this. I stumbled onto the same issue and addressed it in 5ef0baba20bb7c6ebd9b6cb0bda73ba0873fef9f before I got to this PR.