search

jaraco / irc

Full-featured Python IRC library for Python.
MIT License
390 stars 84 forks source link

The internals still rely on VERSION_STRING #174

Closed lu-zero closed 3 years ago

lu-zero commented 3 years ago 
irc/bot.py", line 315, in get_version
    return "Python irc.bot ({version})".format(version=irc.client.VERSION_STRING)
AttributeError: module 'irc.client' has no attribute 'VERSION_STRING'
sbraz commented 3 years ago

This causes tests to fail:

===================================================================================================== ERRORS ======================================================================================================
_________________________________________________________________________________________ ERROR collecting irc/server.py __________________________________________________________________________________________
irc/server.py:62: in <module>                
    SRV_WELCOME = "Welcome to {__name__} v{irc.client.VERSION}.".format(**locals())                      
E   AttributeError: module 'irc.client' has no attribute 'VERSION'                                       
_____________________________________________________________________________________ ERROR collecting irc/tests/test_bot.py ______________________________________________________________________________________
irc/tests/test_bot.py:8: in <module>                                                                                                                                                                               
    import irc.server                                                                                                                                                                                              
irc/server.py:62: in <module>                                                                            
    SRV_WELCOME = "Welcome to {__name__} v{irc.client.VERSION}.".format(**locals())                      
E   AttributeError: module 'irc.client' has no attribute 'VERSION'
_____________________________________________________________________________________ ERROR collecting irc/tests/test_bot.py ______________________________________________________________________________________
irc/tests/test_bot.py:8: in <module>              
    import irc.server                                                                                                                                                                                              
irc/server.py:62: in <module>
    SRV_WELCOME = "Welcome to {__name__} v{irc.client.VERSION}.".format(**locals())                      
E   AttributeError: module 'irc.client' has no attribute 'VERSION'                                       
============================================================================================= short test summary info =============================================================================================
ERROR irc/server.py - AttributeError: module 'irc.client' has no attribute 'VERSION'                     
ERROR irc/tests/test_bot.py - AttributeError: module 'irc.client' has no attribute 'VERSION'
ERROR irc/tests/test_bot.py - AttributeError: module 'irc.client' has no attribute 'VERSION'                                                                                                                       
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
========================================================================================= 1 deselected, 3 errors in 0.21s =========================================================================================
jaraco commented 3 years ago

That's really terrible. Sorry about the consternation this issue has caused. I'd have expected the release not to happen due to the test failures except for jaraco/skeleton#20 :(

I'll get this fixed.