search

jaraco / irc

Full-featured Python IRC library for Python.
MIT License
390 stars 84 forks source link

Catch-all for unhandled events #186

Closed hifi closed 1 year ago

hifi commented 3 years ago

Ignoring pong as it is actually handled but the event is still passed along.

Fixes #185

jaraco commented 3 years ago

Have you considered adding tests for this behavior? This library has historically been pretty bereft of tests, but it would be nice to work toward more test coverage. Otherwise, these lines could be removed and tests would still pass.

hifi commented 3 years ago

I can write tests if they work in the first place. :smile:

jaraco commented 2 years ago

Yes, it seems the tests started failing spontaneously, since the last commit before your contrib passed tests just fine. I've fixed the tests failing at main, so I'll re-open this PR to re-run the tests.

jaraco commented 2 years ago

It looks like the remaining test failures are nitpicky linters. I can fix that by running 'black' on the codebase.

hifi commented 2 years ago

Right, sorry, I need to come around back to this when I continue refactoring again.

jaraco commented 1 year ago

Feel free to re-engage on this issue at your leisure. In the meantime, I'll close the PR.