jaraco
commented
8 years ago Attached a patch anyway. Please test against all environments as I only tested against python 2.7 on linux.
Bottom line:
- It now works as I think it was intended
- Makes two calls to time.time() per function call but I don't think there's gonna be a performance issue.
- Can't see how this could break existing code using set_rate_limit. Still, as was also the case in the previous implementation, one should be wary of where to start the rate limiting, as putting it too early can slow the client's initial connect.
- Testing takes 2 more seconds to run, one of which is a time.sleep()
Original comment by: Nick Raptis
I refrained from reopening issue #18 and opened a new issue instead.
Right now, Throttle and set_rate_limit work fine as long as the calls to the function are made as fast as possible.
However, if the function is not called for some time, a following burst of calls will not get limited. This is not useful as a burst to, for example, send_raw can happen in any point in time.
I propose a different implementation where Throttle keeps the time it was last called and decides to throttle based on that.
If you agree that this should be the intended behavior, I can happily write a patch and also append to the relevant test. However, the test will likely take a couple more seconds to run as I'll need to idle for a bit between bursts.