Closed tradel closed 1 year ago
Looks like I made this change in 885330f8, thinking it was mistakenly trying to match a substring and not a list of strings.
The current test suite asserts 'connectivity' in 'connectivity'
, which is True
, but also would allow get_devices(generic_type='connectivity-king')
to match connectivity
. I don't think that's desirable.
Should be fixed with v3.1.1.
The original
abodepy
library expected thegeneric_type
argument toget_devices()
to be a list of strings orNone
:https://github.com/MisterWil/abodepy/blob/4ffce2314ed7e2c5d48a2c2758fddaef440b05ad/abodepy/__init__.py#L273-L274
This fails in
jaraco.abode
because the new logic tests for equality, not membership in the list:https://github.com/jaraco/jaraco.abode/blob/c82a82f4981d7dcd8e05b3cae665f8ed0c383328/jaraco/abode/client.py#L164
This causes the unit tests in
homeassistant
to fail intest_binary_sensor.py
because the test passes a list of device types.