search

jaraco / jaraco.abode

MIT License
11 stars 9 forks source link

Restore is_on behavior for specialized BinarySensor subclasses #29

Closed jaraco closed 3 months ago

jaraco commented 3 months ago

In home-assistant/core#121300, we learned that https://github.com/jaraco/jaraco.abode/commit/d2b69390ed97a006b05879bc6e5db076ca85369f caused a regression for motion sensors. It turns out that sensor.Sensor and Motion devices also need this behavior (but presumably only when type=Occupancy).

This change adds a test and reverts the offending change to restore behavior selectively.

Future bugs and refactorings will deal with the underlying architectural problems that led to this issue, but this change addresses the symptom to get HA users' expectations restored ASAP.