search

jaraco / keyring

MIT License
1.24k stars 152 forks source link

Add: password entry verification to prevent password mistype #662

Closed abastola0 closed 2 months ago

abastola0 commented 9 months ago

Added a password retype mechanism that helps user verify the password in case the password is mistyped. The number of trials for incorrect passoword attempts is set to 3 for now.

mitya57 commented 9 months ago

Thanks, approved. The final word is @jaraco's, he may have his own comments.

abastola0 commented 9 months ago

@mitya57 diffcov failed in this case. What do you think i might need to change.

mitya57 commented 9 months ago

Well, if you manage to write a test for this code, that would be awesome. If no, then I think we will have to ignore that warning.

jaraco commented 2 months ago

This PR appears to be languishing, so I'm closing for now, but feel free to revive the conversation and we can re-open.