search

jaraco / keyring

MIT License
1.24k stars 152 forks source link

mypy failing again #667

Closed jaraco closed 6 months ago

jaraco commented 6 months ago

Recent releases of mypy have created new failures:

_______________________________________________________ keyring/backends/SecretService.py ________________________________________________________
33: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
33: note:      Superclass:
33: note:          classproperty[int | float]
33: note:      Subclass:
33: note:          classproperty[int]
__________________________________________________________ keyring/backends/Windows.py ___________________________________________________________
84: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
84: note:      Superclass:
84: note:          classproperty[int | float]
84: note:      Subclass:
84: note:          classproperty[int]
__________________________________________________________ keyring/backends/chainer.py ___________________________________________________________
22: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
22: note:      Superclass:
22: note:          classproperty[int | float]
22: note:      Subclass:
22: note:          classproperty[int]
____________________________________________________________ keyring/backends/fail.py ____________________________________________________________
18: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
18: note:      Superclass:
18: note:          classproperty[int | float]
18: note:      Subclass:
18: note:          classproperty[int]
____________________________________________________________ keyring/backends/null.py ____________________________________________________________
14: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
14: note:      Superclass:
14: note:          classproperty[int | float]
14: note:      Subclass:
14: note:          classproperty[int]
jaraco commented 6 months ago

These errors don't make sense to me. If a subclass returns a subset of types supported by the superclass, that's still compatible. shrug

jaraco commented 6 months ago

I welcome others to raise this seemingly false positive with the mypy project.