Deprecate empty usernames

jaraco / keyring

MIT License

1.26k stars 160 forks source link

Closed jaraco closed 3 months ago

jaraco commented 3 months ago

Add a test capturing the missed expectation. Ref #668.
Mark the test as xfail where it's failing (Windows).
Deprecate setting a password for an empty username.
Extract method for registration.
When constructing KeyringBackend subclasses, wrap set_password to enforce non-empty usernames.

jaraco commented 3 months ago

Tests on diffcov are failing, but only because the coverage reports aren't aggregated (jaraco/skeleton#130).

mitya57 commented 3 months ago

or comment in the issue

There will be an issue link generated, right?

jaraco commented 3 months ago

or comment in the issue

There will be an issue link generated, right?

Yes. It will link to #668 in the changelog (from the 668.feature.rst file).