search

jaraco / skeleton

A generic project skeleton for Python projects.
http://blog.jaraco.com/skeleton/
MIT License
123 stars 36 forks source link

"preserve" does not require preview any more #133

Closed DimitriPapadopoulos closed 4 months ago

DimitriPapadopoulos commented 4 months ago

Fixes #131.

jaraco commented 4 months ago

Oh, shoot. As I'm applying this change to all the projects, I'm noticing it's a very sensitive setting. Setuptools, for example, enables this same setting "to get hugged parenthesis unwrapping". I think what that means as that by applying this change, all the projects are going to lose hugged parenthesis unwrapping. I think that's why I was surprised when I saw this diff after applying this latest skeleton. So much foot gun in just one setting.

DimitriPapadopoulos commented 4 months ago

Indeed, preview is a handle for a set of assorted "beta" rules. It's usually not a concern when applied to a single project, but when applied to the skeleton of many projects, I can now see the potential damage caused by the lack of granularity.

Perhaps it was a bad idea to enable preview and its associated "beta" rules in the first place. Experimental behaviour has no place in the dependency of a myriad of projects. But I can see it might be too late to revert.

jaraco commented 4 months ago

Perhaps it was a bad idea to enable preview and its associated "beta" rules in the first place. Experimental behaviour has no place in the dependency of a myriad of projects. But I can see it might be too late to revert.

Unfortunately, the desired behavior (preserve quotes) was only available behind that setting.

Given that all the projects are currently tuned to preview=true, I'm inclined to keep it, to avoid the flux of unhugging the parenthesis and later re-introducing them. I'd rather be on the cutting edge of behavior than to lose these benefits.