Closed Avasam closed 2 months ago
This change fixes an incompatibility (and source of merge conflicts) with projects using Ruff/isort.
I could add the I (https://docs.astral.sh/ruff/rules/#isort-i) category to the Ruff configs (see example from https://github.com/pypa/setuptools/blob/962835d068af4d993f2195e7a6ffd4f70548b9f4/ruff.toml#L60-L62 ). But it would create more conflicts with ongoing https://github.com/jaraco/skeleton/issues/143 . But at the same time, a lot of those PRs already have conflicts from changes in mypy.ini and conf.py, and import-related conflicts are easy to fix (accept both + rerun fixer). So maybe now's not a bad time to add it before I fix conflicts.
I
mypy.ini
conf.py
This change fixes an incompatibility (and source of merge conflicts) with projects using Ruff/isort.
I could add the
I
(https://docs.astral.sh/ruff/rules/#isort-i) category to the Ruff configs (see example from https://github.com/pypa/setuptools/blob/962835d068af4d993f2195e7a6ffd4f70548b9f4/ruff.toml#L60-L62 ). But it would create more conflicts with ongoing https://github.com/jaraco/skeleton/issues/143 . But at the same time, a lot of those PRs already have conflicts from changes inmypy.ini
andconf.py
, and import-related conflicts are easy to fix (accept both + rerun fixer). So maybe now's not a bad time to add it before I fix conflicts.