search

jarad / FluSight

An R package containing functions used in the CDC Flu Forecasting competition
GNU General Public License v3.0
12 stars 7 forks source link

generate_point_forecasts doesn't return anything #19

Open nickreich opened 7 years ago

nickreich commented 7 years ago

Maybe I'm missing something, but I don't think this function returns anything usable. also, it's not clear from the documentation that it is expecting an entry with no rows for Point estimate (as opposed to, say, rows with NA values).

FluSight/R/generate_point_forecasts.R

craigjmcgowan commented 7 years ago

As it's set up now, I believe this function just returns the point forecasts as their own data.frame. It would probably be more useful to integrate the point forecasts into the existing probabilistic forecasts and return a full entry data.frame. I agree that it should be able to take an entry with all NA rows for point estimates and can take a look at adding that later this week.