search

jarcode-foss / glava

GLava - OpenGL audio spectrum visualizer
GNU General Public License v3.0
1.17k stars 59 forks source link

Feature Request: add a setting to only use half the spectrum for bars #123

Closed joshuah345 closed 5 years ago

joshuah345 commented 5 years ago

this would be the same as providing a mono output instead of stereo

notsatvrn commented 5 years ago

I also think this should be added for people who prefer a look similar to the extremely overdone Monstercat Visualizer style

jarcode-foss commented 5 years ago

I will get around to this later. Keep in mind that PRs are always welcome, especially as I am preoccupied by other things nowadays.

jarcode-foss commented 5 years ago

bars will now only render a single channel if #request setmirror true is set in rc.glsl (non-default). You can disable this behavior by setting DISABLE_MONO to 1 in bars.glsl.

I implemented this by exposing a new _CHANNELS macro defined by glava itself so that shaders could read from this request.

Unfortunately this does not have any positive impact on performance at the moment as there are some limitations preventing me from using preprocessor logic with requests. If you are on a system where the performance benefit would help, you can manually remove the section of requests for audio_r in bars/1.frag as a temporary fix.