jarcode-foss / glava

GLava - OpenGL audio spectrum visualizer
GNU General Public License v3.0
1.17k stars 59 forks source link

Various errors encountered with ninja -C build #184

Open dplptp04 opened 3 years ago

dplptp04 commented 3 years ago

After following the required steps for compilation for Debian/Ubuntu on Ubuntu 20.10, git and meson work just fine, but when ninja -C build is run, I get the following:

ninja -C build results.txt

I don't understand much, but it looks like ninja is running into a lot of errors trying to build gLava.

Dib-Roy commented 3 years ago

Exact same setup and problem here as well.

IsaacHorvath commented 3 years ago

I am having this exact issue, and it looks like it broke glava-git in the AUR as well. Here's how I managed to get it to compile after a few hours of debugging:

Add this into the top of glfft/glfft_common.hpp: #include <stdexcept>

And this into the top of glfft/glfft_gl_interface.hpp in the extern "C" { } bracket: #include <errno.h> #include <stdio.h>

And finally, change these two lines in glava/glava.h: __attribute__((noreturn, visibility("default"))) void (*glava_abort) (void); __attribute__((noreturn, visibility("default"))) void (*glava_return) (void); to this: __attribute__((noreturn, visibility("default"))) extern void (*glava_abort) (void); __attribute__((noreturn, visibility("default"))) extern void (*glava_return) (void);

Viibrant commented 3 years ago

I am having this exact issue, and it looks like it broke glava-git in the AUR as well. Here's how I managed to get it to compile after a few hours of debugging:

Add this into the top of glfft/glfft_common.hpp: #include <stdexcept>

And this into the top of glfft/glfft_gl_interface.hpp in the extern "C" { } bracket: #include <errno.h> #include <stdio.h>

And finally, change these two lines in glava/glava.h: __attribute__((noreturn, visibility("default"))) void (*glava_abort) (void); __attribute__((noreturn, visibility("default"))) void (*glava_return) (void); to this: __attribute__((noreturn, visibility("default"))) extern void (*glava_abort) (void); __attribute__((noreturn, visibility("default"))) extern void (*glava_return) (void);

What an absolute legend! Can confirm this completely sorted my problem out. Cheers!!

unclehowell commented 3 years ago

good drills. Why dont these get changed in the repo ?

IsaacHorvath commented 3 years ago

I guess it's been abandoned.

jwakely commented 2 years ago

185 fixes this