search

jaredatch / EA-Share-Count

A lean plugin that leverages SharedCount.com API to quickly retrieve, cache, and display various social sharing counts.
84 stars 13 forks source link

Links should have title attributes #54

Closed jaredatch closed 8 years ago

jaredatch commented 8 years ago

.ea-share-count-button links should have title attribute.

Basically title="Share on {$service}" or similar.

billerickson commented 8 years ago

I started by doing title="Share on ' . $link['label'] but we end up with "Share on Tweet" and "Share on Email".

I think a better approach is to add another parameter to $link called attr_title or something similar. This way we can customize each link's title text, and it's filterable using the ea_share_count_link filter.

billerickson commented 8 years ago

See: https://github.com/jaredatch/EA-Share-Count/tree/issue/54

jaredatch commented 8 years ago

I think that's a good idea. Looks solid to me 👍