search

jaredatch / bbPress-Genesis-Extend

Provides basic compatibility with bbPress and the Genesis Framework with a few extra goodies.
5 stars 5 forks source link

Consider genesis_init instead of after_setup_theme #3

Closed NicktheGeek closed 10 years ago

NicktheGeek commented 10 years ago

Jared, have you thought about using the genesis_init hook instead of the after_setup_theme hook in your init class? This has a couple of advantages. First, I've run into weird issues where from time to time the template is Genesis but I get a white screen because genesis_get_option() is not found. It seems that in very weird cases the logic that loads certain files doesn't seem to complete. Most recently this happened to me when doing a WP update. It isn't super common and seems to rely on several factors but it is kind of annoying when it happens. Using genesis_init should bypass that.

Also, using genesis_init means that you don't have to check the template constant to see if it is Genesis. That will ever so slightly simplify the code.

jaredatch commented 10 years ago

No I hadn't but it makes sense.

Also, I need to update the GH repo. It's behind from what's on .org. Just wanted to make sure you are using/testing what's on .org and not here (http://wordpress.org/plugins/bbpress-genesis-extend/).

jaredatch commented 10 years ago

Alright, I just updated GH to the latest version from .org. So double check any PR that you are using that version :)

jaredatch commented 10 years ago

Works for me. Thanks.

https://github.com/jaredatch/bbPress-Genesis-Extend/commit/f1af57f16adf405ef25b1a4f3b554cf714508943