v1.5 release version unable to select PoE directory and Soundtrack file

[philanderadriaan]

Looks like the v1.5 release introduced a bug from the below commit, where we're unable to select PoE directory and soundtrack file.

https://github.com/jareddr/PoECustomSoundtrack/commit/21f10b5062bb6044e1cf2be075451f0c1faa4dcb

Reverting changes from that commit and then doing a npm install seem to get it working again.

[philanderadriaan]

I managed to narrow down the problem to the electron version in package.json. I reverted it from ~13.2.3 to ~2.0.8, then do a npm install, then it's working again.

[jareddr]

oh thanks for finding this, ill see if I can get the patch out today

On Sun, Feb 13, 2022 at 9:07 AM Phil A @.***> wrote:

I managed to narrow down the problem to the electron version in package.json. I reverted it from ~13.2.3 to ~2.0.8, then do a npm install, then it's working again.

[image: Capture] https://user-images.githubusercontent.com/5098967/153766123-e7345e50-eada-455f-8dff-c07893c03c1c.PNG

— Reply to this email directly, view it on GitHub https://github.com/jareddr/PoECustomSoundtrack/issues/11#issuecomment-1038267234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHZ47OLUCBAJGHPJMXY4LU27QNLANCNFSM5OJJKAYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

[jareddr]

Hmmm this is all working for me @philanderadriaan, did you test to see if it works if you run it from the installer at all?

[philanderadriaan]

Yes I tried it with the release installer.

Installing v1.5 I'm unable to change soundtrack files.

Installing v1.4.4 I'm able to change soundtrack files, then when I update to v1.5 using the updater and I'm unable to change soundtrack files again.

[jareddr]

Ah yeah sorry I figured it out after I wrote you. There was an api change in electron for the showOpenDialog function. The old one took a callback function and the new one returns a promise, so the fix looks like this

// handle file select dialog
function loadLogFile() {
  dialog.showOpenDialog({
    title: 'Locate PoE Directory',
    properties: ['openDirectory'],
  }).then ( results =>{
    ipcRenderer.send('setPoePath', results.filePaths)
  });
}

[philanderadriaan]

Awesome