search

jareddr / PoECustomSoundtrack

A companion app to Path of Exile to play a user defined soundtrack that changes as the player changes areas in game.
10 stars 6 forks source link

Pull Request for Login Screen Music Feature and Controls for Audio tag #2

Closed asetiadi001 closed 6 years ago

asetiadi001 commented 7 years ago

Hi,

I have made 2 main feature in my fork, namely:

I hope you can accept my proposition :)

jareddr commented 7 years ago

Thanks man!

I haven't been able to bring myself to work on this since I first launched it, but I really appreciate your attention on it.

I'll try to check out your changes tonight and will undoubtedly accept your pull request once I've looked.

jareddr commented 7 years ago

Oh also, have you tested this with maps at all? I'm pretty sure the worldAreas.json file is no longer correct for maps since Atlas of Worlds.

All of the world area names need to be updated.

asetiadi001 commented 7 years ago

I haven't tested this with maps yet, will do once I reach merciless LoL. Also, currently, I based the trigger of main menu music with(in parseLogLine function):

line.match(/Changing to device/) ? true:false

I assume PoE will check all audio driver in all clients. Please let me know if you think this should not be the way. Cheers.

jareddr commented 6 years ago

A year later and I finally updated the project! I didn't merge your pull request but I did implement the features you suggested, thanks again!