search

jaredh159 / tailwind-react-native-classnames

simple, expressive API for tailwindcss + react-native
2.08k stars 84 forks source link

Feature/gap #212

Closed rborn closed 1 year ago

rborn commented 1 year ago

for #205 🤗

rborn commented 1 year ago

@jaredh159 ok, fixed theme?.gap and maybe some merge conflicts? The diff looks clean, maybe we can merge ?

jaredh159 commented 1 year ago

@rborn code diff looks good, but i'm a bit of a stickler about keeping my commit history tidy, and you've got duplicated commits, and commits from previous PR's in your history, so i'd rather not merge all of that in. do you know how to clean that up with a rebase? if not, can you maybe add me as a collaborator on your fork, and i'll rebase it and then i can merge?

rborn commented 1 year ago

@jaredh159 yeah, I managed somehow to do a total mess out of this 😅 Now it should be clean, sorry for this

jaredh159 commented 1 year ago

thanks! merged, and pushed out a release: 3.6.0 👍