search

jaredh159 / tailwind-react-native-classnames

simple, expressive API for tailwindcss + react-native
2.08k stars 84 forks source link

fix ordering when using ir cache #227

Closed crjc closed 1 year ago

crjc commented 1 year ago

In an expo application with expo-router, breakpoints on RN web would not work correctly if the window was resized before a navigation event.

the issue was down to the ordering of breakpoints essentially being removed when a utility was cached individually.

jaredh159 commented 1 year ago

hey, appreciate the PR, thanks!

code seems ok, but are you able to write a unit test that captures the failing behavior and the fix?

crjc commented 1 year ago

Not sure if the the test I wrote is very good, but it does fail on master and passes on this branch.

jaredh159 commented 1 year ago

great, thank you! merging 👍 will cut a release shortly

jaredh159 commented 1 year ago

3.6.1 released with your fix, if you want to start depending on it.