search

jaredh159 / tailwind-react-native-classnames

simple, expressive API for tailwindcss + react-native
2.08k stars 84 forks source link

Add sx utility function #278

Closed doong-jo closed 7 months ago

doong-jo commented 9 months ago
iShot_2024-02-24_17 15 04

This is a utility that proves to be useful when wanting to merge internal and external styles within a component. I've been actively using the sx function in my current project, finding it immensely helpful. Hence, I thought it would be a beneficial addition to twnrc.

Currently, we need to receive className as a string and pass it as an argument to tw.style. However, this approach requires developers to manually add the className prop, which can be cumbersome.

sx, on the other hand, mitigates this effort by accepting RN's StyleProp as the second parameter, simplifying the process of passing styles.

jaredh159 commented 8 months ago

Thanks for the contribution!

However, this approach requires developers to manually add the className prop, which can be cumbersome.

I'm confused by what you're describing here. twrnc doesn't use a className prop at all, since that's not a prop on RN components.

And I guess overall, I'm having trouble grokking which pain point this solves, or exactly what value this function is providing. Could you give me some examples of code samples without sx that are awkward or unergonomic, that sx improves?

doong-jo commented 7 months ago

As time goes by, this seems to have something to do with my code style. I don't think it's a necessary change for this repository, so I'll close it. Thanks to your reply