search

jaredh159 / tailwind-react-native-classnames

simple, expressive API for tailwindcss + react-native
2.08k stars 84 forks source link

Fix invalid custom class names #299

Closed Ismaaa closed 5 months ago

jaredh159 commented 5 months ago

Hi there, thanks for taking time to open a PR!

Was this causing a problem for you? I don't think these examples are invalid -- the library's plugin system for registering custom utilities does explicitly support leading dots here, and i think i changed the readme because you get better intellisense from some plugins/editors with the leading dot. but i might be missing something. can you elaborate on what problem this was causing you, or why the readme should be changed?

Ismaaa commented 5 months ago

Hey @jaredh159 ! Thanks for your quick response.

You're correct; the leading dots in the class names within the plugin registration system are technically valid. However, from a conventional standpoint in typical HTML and CSS usage, class names are rarely prefixed with a dot outside of the CSS files themselves. This notation could be perceived as unusual or non-standard.

My intention was to align the examples more closely with common practices for clearer readability and to prevent any potential misunderstanding.

jaredh159 commented 5 months ago

i'm a bit torn, because your reasoning is valid, but i think i'm going to keep them as is, because gently guiding people to write their custom utilities this way helps some with intellisense, and i think that win outweighs the slight confusion from the leading dots. so, i think i'm gonna close this, but truly appreciate the time you put into it.