search

jaredhanson / passport-facebook

Facebook authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-facebook/?utm_source=github&utm_medium=referral&utm_campaign=passport-facebook&utm_content=about
MIT License
1.3k stars 446 forks source link

Dev notice from FB "v2.1 Upgrade Reminder" #180

Open riston opened 8 years ago

riston commented 8 years ago

Email received form Facebook, they are doing the version detection on their side. Only Graph calls to FB are done through this module.

XXXX currently has access to Graph API v2.1 which will reach the end of its 2-year lifetime on 30 October, 2016. To ensure a smooth transition, please migrate all calls to Graph API v2.2 or higher.

In code there is the profile graph query which uses fixed version v2.5, another call is done to Graph API to get the token the problem is that it doesn't have the fixed version (https://graph.facebook.com/oauth/access_token). In API response the headers show that's it's using old version facebook-api-version:v2.1. I am not sure if the v2.1 is removed does it automatically switch to a higher version or should it be fixed? (like https://graph.facebook.com/v2.5/oauth/access_token)

I purpose to set it as fixed version as the profile call.

PR: https://github.com/jaredhanson/passport-facebook/pull/181

sk91 commented 8 years ago

+1

xeroxoid commented 8 years ago

+1

rheathec commented 8 years ago

+1

jamesjjk commented 8 years ago

+1

fiznool commented 7 years ago

Any further progress on this? It seems like a very appropriate change and one that would be welcomed by many.

EDIT: I added a new PR which takes into account feedback from #198.