search

jaredhanson / passport-facebook

Facebook authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-facebook/?utm_source=github&utm_medium=referral&utm_campaign=passport-facebook&utm_content=about
MIT License
1.29k stars 447 forks source link

Update default API to 2.10 #220

Closed rwky closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0139705730aaae987e716ae7a4136a1896038c08 on rwky:master into 82a5d8fb04ec915505a8f46565f511bedaad4bb4 on jaredhanson:master.

rwky commented 6 years ago

Supersedes #199

krishna2nd commented 6 years ago

Please merge this changes

turnerhayes commented 6 years ago

Any update on this? I just got an email from Facebook reminding me that 2.5 is reaching EOL in less than a month, it would be nice to have this in before then.

guyellis commented 6 years ago

@odykyi are you able to merge changes or is it only @jaredhanson ?

rwky commented 6 years ago

This appears to be unmaintained. I've a copy which has been upgraded here https://www.npmjs.com/package/passport-facebook-rwky

However it might be a good idea getting all the passport-* repos put into a organisation and have a few people that can manage it. I'd be happy to help out.

guyellis commented 6 years ago

@rwky can you activate issues on your fork of this so that we can continue working on this until something like that happens? You can do it in the settings tab of the repo. Thanks.

rwky commented 6 years ago

Done, feel free to throw issues in there and I'll take a look.

JSteunou commented 6 years ago

@jaredhanson are you still around? Do you need help to maintain all this?

JSteunou commented 6 years ago

FYI facebook API v2.5 will end in less a month

JSteunou commented 6 years ago

@rwky could you have split up the branch that could be used as a PR here, and your fork branch? Would have been nice to be able to accept the original PR from here someday ;)

rwky commented 6 years ago

@JSteunou I'm working on it. I'll open a new PR in a bit.

rwky commented 6 years ago

I've created a new PR #234 which updates to 2.12. I've also pushed this to npm https://www.npmjs.com/package/passport-facebook-rwky if anyone has any comments on the PR can they add them to #234