search

jaredhanson / passport-facebook

Facebook authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-facebook/?utm_source=github&utm_medium=referral&utm_campaign=passport-facebook&utm_content=about
MIT License
1.29k stars 447 forks source link

Updated API to 2.12 #234

Closed rwky closed 5 years ago

rwky commented 6 years ago

Supersedes #220 #199

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a36693b269ec97272ce8e09e5d24fa4a3fe on rwky:api-version-2.12 into 82a5d8fb04ec915505a8f46565f511bedaad4bb4 on jaredhanson:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a36693b269ec97272ce8e09e5d24fa4a3fe on rwky:api-version-2.12 into 82a5d8fb04ec915505a8f46565f511bedaad4bb4 on jaredhanson:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a36693b269ec97272ce8e09e5d24fa4a3fe on rwky:api-version-2.12 into 82a5d8fb04ec915505a8f46565f511bedaad4bb4 on jaredhanson:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a36693b269ec97272ce8e09e5d24fa4a3fe on rwky:api-version-2.12 into 82a5d8fb04ec915505a8f46565f511bedaad4bb4 on jaredhanson:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8b3e8a36693b269ec97272ce8e09e5d24fa4a3fe on rwky:api-version-2.12 into 82a5d8fb04ec915505a8f46565f511bedaad4bb4 on jaredhanson:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b868a625f18caa0224ec84dc9957a12238d53e7e on rwky:api-version-2.12 into 82a5d8fb04ec915505a8f46565f511bedaad4bb4 on jaredhanson:master.

lumaxis commented 6 years ago

@jaredhanson Any chance we can get this merged and released soon-ish? 🙂 Let me know if I can do anything to help!

ttsirkia commented 6 years ago

Is this repository still maintained or should we use a fork which already includes version 2.12?

isitgeorge commented 6 years ago

Doesn't look like this is going to merged anytime soon. You can also force API 2.12 by modifying the authorizationURL, profileURL and tokenURL parameters.

passport.use(new FacebookStrategy({
    clientID: FACEBOOK_APP_ID,
    clientSecret: FACEBOOK_APP_SECRET,
    callbackURL: "http://localhost:3000/cb",
    profileURL: 'https://graph.facebook.com/v2.12/me',
    authorizationURL: 'https://www.facebook.com/v2.12/dialog/oauth',
    tokenURL: 'https://graph.facebook.com/v2.12/oauth/access_token'
  },
  function(accessToken, refreshToken, profile, cb) {
    ...
  }
));
rwky commented 6 years ago

Merged in https://github.com/passport-next/passport-facebook

jaredhanson commented 5 years ago

I've published passport-facebook@3.0.0 to npm. This version updates to the latest version of Graph API, v3.2. It includes an equivalent graphAPIVersion option, the casing changed to match conventions througout the rest of this and other passport strategies.

Closing.