search

jaredhanson / passport-http

HTTP Basic and Digest authentication strategies for Passport and Node.js.
https://www.passportjs.org/packages/passport-http/?utm_source=github&utm_medium=referral&utm_campaign=passport-http&utm_content=about
MIT License
268 stars 110 forks source link

Allow Digest strategy to work with mounted apps #16

Closed ghost closed 4 years ago

ghost commented 11 years ago

The Authorization header's uri field is checked against request.url, which doesn't work for mounted apps. This can be fixed by checking against request.originalUrl instead, when it is present.

deckchairhq commented 10 years ago

+1

kierans commented 10 years ago

+1 Why hasn't this been merged yet? It's a pretty critical bug given how many apps would use mount points for Router instances.

kierans commented 10 years ago

@wrpl Can you get the CI build to pass so that this fix has a higher priority of being merged?

ghost commented 10 years ago

To be honest the past year or so has led in many new directions. My resources are being used to capacity at the moment and are devoted to other projects. I probably won’t be able to code on this any time soon.

William Riley-Land Founder & API Engineer Kun.io App Studio LLC http://kun.io/wprl

On Aug 14, 2014, at 5:11 AM, Kieran Simpson notifications@github.com wrote:

@wrpl Can you get the CI build to pass so that this fix has a higher priority of being merged?

— Reply to this email directly or view it on GitHub.