search

jaredhanson / passport-http

HTTP Basic and Digest authentication strategies for Passport and Node.js.
https://www.passportjs.org/packages/passport-http/?utm_source=github&utm_medium=referral&utm_campaign=passport-http&utm_content=about
MIT License
268 stars 110 forks source link

Depends on passport ~0.1.3 #36

Closed nickcmaynard closed 9 years ago

nickcmaynard commented 10 years ago

Really rather out of date now. This means that passport-http currently picks up passport#0.1.18.

Suggest we update this to be current.

demmer commented 10 years ago

+1 to this

nickcmaynard commented 10 years ago

Turns out this might have a nasty side-effect - passport/lib/http/request.js always augments the req prototype, regardless of whether it's already augmented.

This means an up-to-date passport's newer login and logout functions get blown away by old versions when passport-http gets pulled in.

nickcmaynard commented 10 years ago

I'd suggest an approach similar to that which passport-local takes with dependencies to fix this: https://github.com/jaredhanson/passport-local/commit/3a2c3750f6ca202d2f67216723536bbf71d980cb

nickcmaynard commented 10 years ago

Indeed, this would help too - replace the dependency with passport-strategy https://github.com/jaredhanson/passport-local/commit/980d67d2ce370f8b3349f859f9af8af0274324e9. I'll take a look at this and see if I can throw together a PR.

nickcmaynard commented 10 years ago

Holding fire on that PR - looks like we have a number of competing issues/PRs for the same sort of thing. Julson's work in https://github.com/jaredhanson/passport-http/pull/35 looks pretty good, so I'd suggest we concentrate on that.

jaredhanson commented 9 years ago

Fixed by merging #35.