search

jaredhanson / passport-http

HTTP Basic and Digest authentication strategies for Passport and Node.js.
https://www.passportjs.org/packages/passport-http/?utm_source=github&utm_medium=referral&utm_campaign=passport-http&utm_content=about
MIT License
268 stars 110 forks source link

Passwords containing ':' are not read properly #41

Open Cybolic opened 9 years ago

Cybolic commented 9 years ago

Since userid and password are read as index 0 and 1 of credentials.split(':') the remaining part of the password after ':' is discarded.

lordgraysith commented 8 years ago

So... over a year and nobody else seems to care about this? This is tripping us up. Can we please merge the PR? https://github.com/jaredhanson/passport-http/issues/42

lordgraysith commented 8 years ago

For anybody else who needs to fix this now, just URL encode your password on the client and then decode it on the server. Maybe we should suggest that in the docs?

fisch3r commented 7 years ago

go and merge!

matzetronic commented 7 years ago

Please merge #42 - this is a blocker for us, thanks!

ebaynaud commented 4 years ago

Duplicate of https://github.com/jaredhanson/passport-http/issues/20