Remove mention of non-existent "session" option

jaredhanson / passport-local

Username and password authentication strategy for Passport and Node.js.

https://www.passportjs.org/packages/passport-local/?utm_source=github&utm_medium=referral&utm_campaign=passport-local&utm_content=about

MIT License

2.74k stars 498 forks source link

Remove mention of non-existent "session" option #120

Open JamesMGreene opened 9 years ago

JamesMGreene commented 9 years ago

The README makes some references to an option called "session" that were added in commit https://github.com/jaredhanson/passport-local/commit/06d290bf07c5cfcff1ef72cba8edc93bc6ca9cbc

The codebase does not contain any such option today, nor did it at the time of that commit (i.e. if you look at https://github.com/jaredhanson/passport-local/tree/06d290bf07c5cfcff1ef72cba8edc93bc6ca9cbc ).

This was confusing for me... probably for others as well.

weblancaster commented 8 years ago

Agree @JamesMGreene came here just to check if session exist in the code

micmro commented 7 years ago

@jaredhanson I ran into this issue as well. Any chance to merge this PR?

kafein commented 7 years ago

ping @jaredhanson

rwky commented 6 years ago

Merged in https://github.com/passport-next/passport-local

gunhaxxor commented 3 years ago

I too was really confused by the session-option in the documentation. @jaredhanson is it possible to merge this into the main-library? Or is it perhaps recommended to adopt the usage of passport-next where this fix was merged?