Add callbackURL to request params

jaredhanson / passport-oauth1

OAuth 1.0 authentication strategy for Passport and Node.js.

https://www.passportjs.org/packages/passport-oauth1/?utm_source=github&utm_medium=referral&utm_campaign=passport-oauth1&utm_content=about

MIT License

24 stars 31 forks source link

Add callbackURL to request params #7

Closed fumikito closed 8 years ago

fumikito commented 8 years ago

It seems that:

Current request param looses redirect URL even if it's set.
So your user can't come back to your application.

This problem seems to have something with this issue of passport-oauth.

I tried OAuth 1.0a ready WordPress' OAuth Rest server and confirmed this patch will fix it. Test passed.

fumikito commented 8 years ago

@jaredhanson How about my PR? I'm afraid about check tool's failures.

jaredhanson commented 8 years ago

I've merged this and then corrected it to only add the redirect URL if the callback is not confirmed, as seen in a8cdf3b

Adding oauth_callback to the user authorization request is defined by OAuth 1.0. However, OAuth 1.0a revises the specification, and expects oauth_callback to be supplied in the request token request.

Any strategies that use OAuth 1.0a and continue to require oauth_callback in the user authorization request will need to add it explicitly by overriding userAuthorizationParams().

fumikito commented 8 years ago

@jaredhanson Thanks for detailed description!